Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API review changes #30526

Merged
merged 1 commit into from
Mar 27, 2023
Merged

API review changes #30526

merged 1 commit into from
Mar 27, 2023

Conversation

ajcvickers
Copy link
Member

Part of #30306

  • Make DbContextOptionsBuilder.ResolveRootApplicationServiceProvider a parameterless overload of UseRootApplicationServiceProvider
  • Make NavigationEntry.LoadWithIdentityResolution an overload of Load with a flags enum with a ForceIdentityResolution value
  • Ensure all interceptor data classes (including MaterializationInterceptionData) have pubternal ctors
  • Move the serviceType parameter to the second position in IConventionEntityType.AddServiceProperty
  • Collapse the overloads of RuntimeEntityType.AddServiceProperty. A serviceType of null means the type is inferred.
  • Add Is prefix to RelationalOptionsExtension.ConnectionOwned
  • Make the parameter names of SqlServerDbFunctionsExtensions.DateDiffMillisecond consistent with other functions (e.g. Rename startTime to startTimeSpan)
  • Instead of adding ignoreNonVirtualNavigations to ProxiesExtensions.UseLazyLoadingProxies, add a nested closure overload with a builder. The builder overload shouldn't include the useproxies parameter.

@ajcvickers ajcvickers requested a review from a team March 20, 2023 00:18
@ajcvickers
API review changes
776bb8e 
Part of #30306

- Make DbContextOptionsBuilder.ResolveRootApplicationServiceProvider a parameterless overload of UseRootApplicationServiceProvider
- Make NavigationEntry.LoadWithIdentityResolution an overload of Load with a flags enum with a ForceIdentityResolution value
- Ensure all interceptor data classes (including MaterializationInterceptionData) have pubternal ctors
- Move the serviceType parameter to the second position in IConventionEntityType.AddServiceProperty
- Collapse the overloads of RuntimeEntityType.AddServiceProperty. A serviceType of null means the type is inferred.
- Add *Is* prefix to RelationalOptionsExtension.ConnectionOwned
- Make the parameter names of SqlServerDbFunctionsExtensions.DateDiffMillisecond consistent with other functions (e.g. Rename startTime to startTimeSpan)
- Instead of adding ignoreNonVirtualNavigations to ProxiesExtensions.UseLazyLoadingProxies, add a nested closure overload with a builder. The builder overload shouldn't include the useproxies parameter.
@ajcvickers
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ajcvickers ajcvickers merged commit a1855d0 into main Mar 27, 2023
@ajcvickers ajcvickers deleted the ApplePearIcaco0319 branch March 27, 2023 18:37
@ajcvickers ajcvickers mentioned this pull request Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajcvickers @AndriySvyryd