Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #30072 : Add Generic version of EntityTypeConfiguration Attribute #30653

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Fix #30072 : Add Generic version of EntityTypeConfiguration Attribute #30653

merged 4 commits into from
Apr 25, 2023

Conversation

OsamaAbuSitta
Copy link
Contributor

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - I add generic version of `EntityTypeConfigurationAttribute<TConfiguration, TEntity>` in the EFCore poject
        - I add Test method in `EntityTypeConfigurationAttribute_should_apply_configuration_to_EntityType_Generic`

        Fixes #30072
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@OsamaAbuSitta
Copy link
Contributor Author

@dotnet-policy-service agree

@ajcvickers ajcvickers merged commit bcc870a into dotnet:main Apr 25, 2023
@ajcvickers
Copy link
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants