Allow value comparers for supertypes of the mapping's type #30939
Conversation
Necessary for primitive collection, where e.g. the comparer has type IList<int> but the type mapping is for the concrete List<int>. Related to/part of dotnet#25364
|
Hello @roji! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
ghost
merged commit 
| $"Expected {clrType}, got {parameters.Comparer?.Type}"); | ||
| if (parameters.Comparer?.Type == clrType) | ||
| if (parameters.Comparer?.Type.IsAssignableFrom(clrType) == true) |
There was a problem hiding this comment.
I'm not familiar with the EFCore codebase, but could this be simplified from:
if (parameters.Comparer?.Type.IsAssignableFrom(clrType) == true)to:
if (parameters.Comparer?.Type.IsAssignableFrom(clrType))
There was a problem hiding this comment.
It could be null, so the options are
if (parameters.Comparer?.Type.IsAssignableFrom(clrType) == true)and
if (parameters.Comparer?.Type.IsAssignableFrom(clrType) ?? false)There was a problem hiding this comment.
Good point. And I wouldn't have ever have thought of your second option.
Necessary for primitive collection, where e.g. the comparer has type IList but the type mapping is for the concrete List.
Related to/part of #25364