Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes scaffolding on Synapse (triggers) #31011

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Fixes scaffolding on Synapse (triggers) #31011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,11 @@ private static string EscapeLiteral(string s)
}

GetForeignKeys(connection, tables, tableFilterSql);
GetTriggers(connection, tables, tableFilterSql);

if (SupportsTriggers())
{
GetTriggers(connection, tables, tableFilterSql);
}

foreach (var table in tables)
{
Expand Down Expand Up @@ -1372,6 +1376,9 @@ private bool SupportsIndexes()
private bool SupportsViews()
=> _engineEdition != 1000;

private bool SupportsTriggers()
=> _engineEdition is not 6 and not 11 and not 1000;

private static string DisplayName(string? schema, string name)
=> (!string.IsNullOrEmpty(schema) ? schema + "." : "") + name;

Expand Down
Loading