[release/8.0] Stop throwing for complex type properties when sensitive data logging is on #32285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e data logging is on Fixes #32198 ### Description Property instances can now belong to complex types, which is a new feature in 8.0. However, logging of a change made to such a property incorrectly assumes the property must be on an entity type. ### Customer impact Exception when using new feature in 8.0 when sensitive data logging is turned on, which is common. ### How found Customer reported on 8.0 rc ### Regression No; complex types are a new feature in 8.0 ### Testing Added tests. ### Risk Very low; fixing an invalid cast.
roji
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32198
Description
Property instances can now belong to complex types, which is a new feature in 8.0. However, logging of a change made to such a property incorrectly assumes the property must be on an entity type.
Customer impact
Exception when using new feature in 8.0 when sensitive data logging is turned on, which is common.
How found
Customer reported on 8.0 RC
Regression
No; complex types are a new feature in 8.0
Testing
Added tests.
Risk
Very low; fixing an invalid cast.