Stop keeping a reference to the model in LazyLoader instances and the Castle interceptor #32388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Castle interceptor Fixes #32348
| private ILazyLoader? _loader; | ||
| private readonly Dictionary<string, bool> _navigations; |
There was a problem hiding this comment.
You can use HashSet for both of these, just don't store the navigations that don't match the criteria.
There was a problem hiding this comment.
We actually use both pieces of information--is this a navigation (as opposed to some other property or a nonsense string) and whether or not is it enabled for lazy-loading.
AndriySvyryd
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32348