Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos: Generate ordinal values for key properties that used not to be persisted. #32469

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

AndriySvyryd
Copy link
Member

Fixes #32363
Fixes #32410

While this should make it possible to query the old records #31933 still needs to be documented as a breaking change because the affected properties are no longer store generated.

@AndriySvyryd AndriySvyryd requested a review from a team December 1, 2023 01:36
@ajcvickers
Copy link
Member

@AndriySvyryd What happens if some of the documents have saved values and some don't? Could the generated values clash?

@AndriySvyryd
Copy link
Member Author

Cosmos doesn't support partial updates yet, so that can't happen

@AndriySvyryd AndriySvyryd merged commit 98d7065 into main Dec 1, 2023
7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue32363 branch December 1, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants