Use current value in update pipeline when original value is not being tracked #32480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tracked Fixes #32168 The issue here is that when using changed/changing notifications, we don't store original values for non-key/index properties. However, in one path, the update pipeline is assuming that asking for original values is always safe since if there isn't one, then a current value is returned. However, this doesn't work if original values are _never_ saved for a given property. In that case, we need to explicitly ask for a current value instead.
ajcvickers
force-pushed
the
231201_WayTooOriginal
branch
from
9e6e493
to
5928ee0
Compare
AndriySvyryd
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32168
The issue here is that when using changed/changing notifications, we don't store original values for non-key/index properties. However, in one path, the update pipeline is assuming that asking for original values is always safe since if there isn't one, then a current value is returned. However, this doesn't work if original values are never saved for a given property. In that case, we need to explicitly ask for a current value instead.