Update Grpc.AspNetCore #32500
Merged
Update Grpc.AspNetCore #32500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for Windows ARM64.
Per discussion with James
AndriySvyryd
reviewed
Dec 5, 2023
| @@ -10,6 +10,7 @@ | |||
| <IncludeSymbols>true</IncludeSymbols> | |||
| <ImplicitUsings>true</ImplicitUsings> | |||
| <NoWarn>$(NoWarn);8981</NoWarn> | |||
| <TargetOsName Condition=" '$(TargetOsName)' == '' AND $([MSBuild]::IsOSPlatform('OSX'))">osx</TargetOsName> | |||
| </PropertyGroup> | |||
There was a problem hiding this comment.
You also need something like this:
<DefineConstants>$(DefineConstants);$(TargetOsName)</DefineConstants>
There was a problem hiding this comment.
Yeah, I think I figured it out now. I am weak with the MSBuild.
AndriySvyryd
approved these changes
Dec 5, 2023
AndriySvyryd
reviewed
Dec 5, 2023
test/EFCore.AspNet.Specification.Tests/EFCore.AspNet.Specification.Tests.csproj
Outdated
Show resolved
Hide resolved
…tion.Tests.csproj Co-authored-by: Andriy Svyryd <AndriySvyryd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for Windows ARM64.