Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to #1015 - Remove QueryBugsTest class #32542

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix to #1015 - Remove QueryBugsTest class #32542

merged 1 commit into from
Dec 8, 2023

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Dec 7, 2023

  • Moving tests from QueryBugsTests to other more appropriate places (either AssertQuery - enabled or proper AdHoc suites)
  • Adding a bunch of AdHoc suites (navigations, splitting, filters, weird mappings)
  • Unified format of AdHoc tests

Resolves #1015

@maumar maumar requested a review from a team December 7, 2023 11:34
@maumar maumar force-pushed the fix1015 branch 4 times, most recently from 1669b59 to d058ddf Compare December 8, 2023 12:22
@maumar maumar mentioned this pull request Dec 8, 2023
Open
@maumar
Fix to #1015 - Remove QueryBugsTest class
3b785ed 
- Moving tests from QueryBugsTests to other more appropriate places (either AssertQuery - enabled or proper AdHoc suites)
- Adding a bunch of AdHoc suites (navigations, splitting, filters, weird mappings)
- Unified format of AdHoc tests

Resolves #1015
@maumar maumar merged commit d1124fa into main Dec 8, 2023
7 checks passed
@maumar maumar deleted the fix1015 branch December 8, 2023 23:52
roji
roji reviewed Feb 11, 2024
View reviewed changes
test/EFCore.Specification.Tests/Query/AdHocNavigationsQueryTestBase.cs

foreach (var blog in query)
{
query.ToList();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maumar this test relies on MARS capabilities, and so fails on PG. Maybe move this to AdHocNavigationsQuerySqlServerTest? The idea is not to burden 3rd-party provider maintainers with too many failing tests out-of-the-box that don't really concern them etc.

Copy link
Member

@roji roji Feb 11, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing with AdHocMiscellaneousQueryTestBase.Nested_queries_does_not_cause_concurrency_exception_sync and Select_nested_projection.

@roji roji mentioned this pull request Feb 17, 2024
Merged
@lauxjpn lauxjpn mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji left review comments

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove QueryBugsTest class
3 participants
@maumar @roji @AndriySvyryd