Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffolding Change -d option to -m, since -d no longer works #32606

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ajcvickers
Copy link
Member

This has been broken form 6 onwards. It's possible the tools will revert their break, but there doesn't seem much value in keeping -d at this point.

-m stands for "mapping attributes" ¯_(``)_/¯

Fixes #26687

This has been broken form 6 onwards. It's possible the tools will revert their break, but there doesn't seem much value in keeping -d at this point.

-m stands for "mapping attributes" ¯\_(``)_/¯

Fixes #26687
@ajcvickers ajcvickers requested a review from a team December 13, 2023 15:20
@ErikEJ
Copy link
Contributor

ErikEJ commented Dec 13, 2023

Breaking change? Or already too broken?

@ajcvickers
Copy link
Member Author

It's only a breaking change when moving from an unsupported version.

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add tests that would fail if one of the options is broken in this way again?

@ajcvickers ajcvickers merged commit 5bceb5e into main Dec 14, 2023
7 checks passed
@ajcvickers ajcvickers deleted the 231213_ShortsForBoys branch December 14, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet ef dbcontext scaffold doesn't respect -d option
3 participants