Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't detect join table with other incoming references as a simple join table #32627

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Don't detect join table with other incoming references as a simple join table #32627

merged 1 commit into from
Dec 16, 2023

Conversation

ajcvickers
Copy link
Member

Fixes #28905

@ajcvickers ajcvickers requested a review from a team December 15, 2023 18:17
@ErikEJ
Copy link
Contributor

ErikEJ commented Dec 15, 2023 •
edited

Wonder if this also affects #32571 ?

@ajcvickers
Copy link
Member Author

@ErikEJ Yep. :-) I ran into that exception while testing this. I need to investigate whether both sides are expecting the same thing with regards to generating navigations.

@ajcvickers ajcvickers merged commit 9b0f169 into main Dec 16, 2023
7 checks passed
@ajcvickers ajcvickers deleted the 231214_RebelYell branch December 16, 2023 11:03
@ajcvickers ajcvickers mentioned this pull request Dec 17, 2023
Closed
ajcvickers added a commit that referenced this pull request Jan 5, 2024
@ajcvickers
Don't detect join table with other incoming references as a simple jo…
30ca290 
…in table (#32627)

Fixes #28905
@ajcvickers ajcvickers mentioned this pull request Jan 5, 2024
Merged
ajcvickers added a commit that referenced this pull request Jan 10, 2024
@ajcvickers
[release/8.0] Don't detect join table with other incoming references …
7fa510b 
…as a simple join table (#32729)

* Don't detect join table with other incoming references as a simple join table (#32627)

Fixes #28905

* Add quirk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect simple join table determination in reverse engineering leads to incorrect code generation
3 participants
@ajcvickers @ErikEJ @AndriySvyryd