Query: Make GroupJoinInclude in compiled query thread safe #6119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this one & creating PR against hotfix1.0.1 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5456
Issue:
GroupJoinIncludein compiled query has querycontext as field which is initialized while iterating query. If the same query is ran from different thread and uses the cached entry then the querycontext inGroupJoinIncludegets changed. Which means only 1 query will have correct context, rest of them will be using incorrect data hence causing exception.Solution: Make
GroupJoinIncludeimmutable and use different data structure which is context based for each query.Same applies to async case.