Resolve -From arguments in Script-Migration [WRONG BRANCH] #6279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameworkCore.Relational.Tests This is required to build the package when referencing the test specification as a package (instead of as a src)
# Conflicts: # test/Microsoft.EntityFrameworkCore.FunctionalTests/project.json # test/Microsoft.EntityFrameworkCore.InMemory.FunctionalTests/project.json # test/Microsoft.EntityFrameworkCore.Microbenchmarks.EF6/project.json # test/Microsoft.EntityFrameworkCore.Microbenchmarks/project.json # test/Microsoft.EntityFrameworkCore.SqlServer.Design.FunctionalTests/project.json # test/Microsoft.EntityFrameworkCore.SqlServer.FunctionalTests/project.json # test/Microsoft.EntityFrameworkCore.Sqlite.FunctionalTests/project.json # test/Microsoft.EntityFrameworkCore.Tests/project.json
|
Nit: probably time to rebase. GH is picking up commits not related to the actual PR |
| @"ALTER TABLE ""Table1"" RENAME TO ""Table2""; | ||
|
|
||
| INSERT INTO ""__EFMigrationsHistory"" (""MigrationId"", ""ProductVersion"") | ||
| VALUES ('00000000000002_Migration2', '7.0.0-test'); |
There was a problem hiding this comment.
Nit: EF 7? What's that? 
|
LGTM. |
|
Closing. My merges into branch got renamed and it's messed up the PR. |
bricelam
changed the title
|
If only we had known this was coming ;) https://github.com/blog/2224-change-the-base-branch-of-a-pull-request |
|
Ha! About time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6126 & fixes #6228