Query: Use discriminator type to create the discriminator constant values #7448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
intdiscriminator7359
branch
from
49199a4
to
00ad96d
Compare
|
|
smitpatel
force-pushed
the
intdiscriminator7359
branch
from
00ad96d
to
138dd82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7359
Whenever we make comparison of discriminator using
EF.Propertythe property expression is generated to be null-able type. If the value is non-nullable type (like int) then it throws exception due to strong typing ofExpression.Equal. Fix is to create the constant for value of type of the property expression to avoid mis-match.It surfaces in materializer for shadow properties. For CLR property the
isoperator in predicate would throw exception.