Skip to content

Commit

Permalink
Skip broken JSInterop tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanbrandenburg committed Jan 29, 2019
1 parent 38620b4 commit bda42eb
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/JSInterop/Microsoft.JSInterop/test/DotNetDispatcherTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public void CannotInvokeUnsuitableMethods(string methodIdentifier)
Assert.Equal($"The assembly '{thisAssemblyName}' does not contain a public method with [JSInvokableAttribute(\"{methodIdentifier}\")].", ex.Message);
}

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1733")]
public Task CanInvokeStaticVoidMethod() => WithJSRuntime(jsRuntime =>
{
// Arrange/Act
Expand Down Expand Up @@ -109,7 +109,7 @@ public void CannotInvokeUnsuitableMethods(string methodIdentifier)
Assert.Equal(456, result.IntVal);
});

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1733")]
public Task CanInvokeStaticWithParams() => WithJSRuntime(jsRuntime =>
{
// Arrange: Track a .NET object to use as an arg
Expand Down Expand Up @@ -140,7 +140,7 @@ public void CannotInvokeUnsuitableMethods(string methodIdentifier)
Assert.Equal(1299, resultDto2.IntVal);
});

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1733")]
public Task CanInvokeInstanceVoidMethod() => WithJSRuntime(jsRuntime =>
{
// Arrange: Track some instance
Expand All @@ -155,7 +155,7 @@ public void CannotInvokeUnsuitableMethods(string methodIdentifier)
Assert.True(targetInstance.DidInvokeMyInvocableInstanceVoid);
});

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1733")]
public Task CanInvokeBaseInstanceVoidMethod() => WithJSRuntime(jsRuntime =>
{
// Arrange: Track some instance
Expand Down Expand Up @@ -206,7 +206,7 @@ public void CannotInvokeUnsuitableMethods(string methodIdentifier)
Assert.StartsWith("There is no tracked object with id '1'.", ex.Message);
});

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1733")]
public Task CanInvokeInstanceMethodWithParams() => WithJSRuntime(jsRuntime =>
{
// Arrange: Track some instance plus another object we'll pass as a param
Expand Down Expand Up @@ -242,7 +242,7 @@ public void CannotInvokeWithIncorrectNumberOfParams()
Assert.Equal("In call to 'InvocableStaticWithParams', expected 3 parameters but received 4.", ex.Message);
}

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1733")]
public Task CanInvokeAsyncMethod() => WithJSRuntime(async jsRuntime =>
{
// Arrange: Track some instance plus another object we'll pass as a param
Expand Down

0 comments on commit bda42eb

Please sign in to comment.