Port config fix to 2.2

[HaoK]

@ajcvickers

[HaoK]

There's no reload for user secrets in 2.2 so those tests had to be removed

[ajcvickers]

Original PR: #1202
Issue: #1189

Description

There is a race condition that can be hit if a file is being updated while the configuration system is refreshing configuration from that file.

Customer Impact

Customer reported. Application crashes with exception.

Regression?

No; same behavior in 2.1. At this time, we're bring for 2.2 only.

Risk

Low. Configuration system is relatively small and code change is simple.

[martincostello]

For my own curiosity, how often does "Shiproom" meet to discuss such proposed changes?

[ajcvickers]

@martincostello Usually twice per week.

[martincostello]

Thanks - I was just wondering as I was reviewing our production logs from over the weekend and we had a handful of the exception occur, so I just wanted to what the status was.

[dougbu]

This fix is incomplete without an update to eng/PatchConfig.props.

[vivmishra]

Approved for 2.2.4
Checkin after branding update @dougbu

[HaoK]

@dougbu what am I supposed to do to patchconfig.props?

[martincostello]

I think Microsoft.Extensions.Configuration.KeyPerFile and Microsoft.Extensions.Configuration.EnvironmentVariables need adding to the 2.2.4 node.

[HaoK]

Alright, @dougbu updated patchconfig

[dougbu]

Looks complete from an eng perspective.

@HaoK I resolved the conflict with my branding update. You're good to go here because that's in. (2.1.10 branding is still pending right this minute.)

[HaoK]

Hrm build checks are red after updating the patch config... any ideas @dougbu ?

WARNING: 0 error(s) and 2 warning(s) found with package Microsoft.Extensions.Configuration.EnvironmentVariables (2.2.4-servicing-19164-12)
WARNING: ASSEMBLY_FILE_VERSION_MISMATCH @ lib/netstandard2.0/Microsoft.Extensions.Configuration.EnvironmentVariables.dll: The managed assembly file version '2.2.0.19073' does not match the package version '2.2.4-servicing-19164-12' for package Microsoft.Extensions.Configuration.EnvironmentVariables.
WARNING: ASSEMBLY_VERSION_MISMATCH @ lib/netstandard2.0/Microsoft.Extensions.Configuration.EnvironmentVariables.dll: The managed assembly version '2.2.0.0' does not match the package version '2.2.4.0' for package Microsoft.Extensions.Configuration.EnvironmentVariables.
INFO: Analyzing Microsoft.Extensions.Configuration.KeyPerFile (2.2.4-servicing-19164-12)
WARNING: 0 error(s) and 2 warning(s) found with package Microsoft.Extensions.Configuration.KeyPerFile (2.2.4-servicing-19164-12)
WARNING: ASSEMBLY_FILE_VERSION_MISMATCH @ lib/netstandard2.0/Microsoft.Extensions.Configuration.KeyPerFile.dll: The managed assembly file version '2.2.0.19073' does not match the package version '2.2.4-servicing-19164-12' for package Microsoft.Extensions.Configuration.KeyPerFile.
WARNING: ASSEMBLY_VERSION_MISMATCH @ lib/netstandard2.0/Microsoft.Extensions.Configuration.KeyPerFile.dll: The managed assembly version '2.2.0.0' does not match the package version '2.2.4.0' for package Microsoft.Extensions.Configuration.KeyPerFile.
WARNING: Unnecessary exclusion in Microsoft.Extensions.Logging.Testing
Issue: BUILD_ITEMS_FRAMEWORK
Instance: *

Showing JSON for ignore content:
{
dotnet.exe failed with exit code: 1
  "Microsoft.Extensions.Configuration.EnvironmentVariables": {
At D:\a\.dotnet\buildtools\korebuild\2.2.1-build-20190104.5\scripts\common.psm1:11 char:9
+         throw "$cmdName failed with exit code: $exitCode"
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (dotnet.exe failed with exit code: 1:String) [], RuntimeException
    + FullyQualifiedErrorId : dotnet.exe failed with exit code: 1
 
    "Exclusions": {
      "ASSEMBLY_FILE_VERSION_MISMATCH": {
        "lib/netstandard2.0/Microsoft.Extensions.Configuration.EnvironmentVariables.dll": "Enter justification"
      },
      "ASSEMBLY_VERSION_MISMATCH": {
        "lib/netstandard2.0/Microsoft.Extensions.Configuration.EnvironmentVariables.dll": "Enter justification"
      }
    }
  },
  "Microsoft.Extensions.Configuration.KeyPerFile": {
    "Exclusions": {
      "ASSEMBLY_FILE_VERSION_MISMATCH": {
        "lib/netstandard2.0/Microsoft.Extensions.Configuration.KeyPerFile.dll": "Enter justification"
      },
      "ASSEMBLY_VERSION_MISMATCH": {
        "lib/netstandard2.0/Microsoft.Extensions.Configuration.KeyPerFile.dll": "Enter justification"
      }
    }
  }
}

[dougbu]

Oh well, this isn't quite ready to go

[dougbu]

@HaoK will get back to you on the version mismatches once I get home. Things aren't working as they should…

[dougbu]

@HaoK didn't find similar changes elsewhere,. But, I'm guessing the package verifier is correct.

Add the following to the Default/packages array in eng/NuGetPackageVerifier.json:

  "Microsoft.Extensions.Configuration.EnvironmentVariables": {
    "Exclusions": {
      "ASSEMBLY_FILE_VERSION_MISMATCH": {
        "lib/netstandard2.0/Microsoft.Extensions.Configuration.EnvironmentVariables.dll": "Enter justification"
      },
      "ASSEMBLY_VERSION_MISMATCH": {
        "lib/netstandard2.0/Microsoft.Extensions.Configuration.EnvironmentVariables.dll": "Enter justification"
      }
    }
  },
  "Microsoft.Extensions.Configuration.KeyPerFile": {
    "Exclusions": {
      "ASSEMBLY_FILE_VERSION_MISMATCH": {
        "lib/netstandard2.0/Microsoft.Extensions.Configuration.KeyPerFile.dll": "Enter justification"
      },
      "ASSEMBLY_VERSION_MISMATCH": {
        "lib/netstandard2.0/Microsoft.Extensions.Configuration.KeyPerFile.dll": "Enter justification"
      }
    }
  }

[HaoK]

Cool that was it, green now @dougbu