Handle operating system shutdown by overriding OnShutdown()

[peval27]

Summary of the changes

• overridden ServiceBase.OnShutdown() to get notified on OS shutdown

Addresses #2699

[analogrelay]

I was about to ask "can you add a test" but then I realized that would be very tricky ;).

[peval27]

Yeah I don't see too much existing unit testing here

[peval27]

BTW I saw you added milestone 5.0.0. what's the ETA? The released one is 3, so I assume quite a long time here. Wouldn't be possible to squash his big fix in a maintenance 3.0.x

[analogrelay]

Yeah I don't see too much existing unit testing here

Well, and testing something that requires shutting down the machine doesn't really lend itself to an automated test ;).

The full roadmap can be found here: https://github.com/dotnet/core/blob/master/roadmap.md

BTW I saw you added milestone 5.0.0. what's the ETA? The released one is 3, so I assume quite a long time here. Wouldn't be possible to squash his big fix in a maintenance 3.0.x

5.0 is the next release after 3.1 (which is locked down for release in December), we're skipping 4.x to avoid conflicts with .NET Framework. The ETA is November 2020.

We don't generally add functionality in a maintenance release. We never provided support for the OnShutdown event in the past so this isn't really a regression. Can you provide any details on what scenarios are blocked in your environment? Given that this can be worked around by registering your own version of WindowsServiceLifetime in the container (based on this fixed code), I think this wouldn't meet the servicing bar.

[dnfclas]

All CLA requirements met.

[Tratcher]

Thanks