Revert "Revert "Remove ref project from Microsoft.AspNetCore.Testing"" #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
added
servicing-consider
JunTaoLuo
approved these changes
Feb 5, 2020
|
Related: dotnet/aspnetcore#18803 |
wtgodbe
added
area-infrastructure
and removed
servicing-consider
Pilchie
approved these changes
Feb 5, 2020
dougbu
approved these changes
Feb 5, 2020
| <!-- This package is internal, so we don't generate a package baseline. Always build against the latest dependencies. --> | ||
| <UseLatestPackageReferences>true</UseLatestPackageReferences> | ||
| <IsProjectReferenceProvider>false</IsProjectReferenceProvider> |
There was a problem hiding this comment.
FYI the need to disable $(IsProjectReferenceProvider) i.e. to do more than turn $(HasReferenceAssembly) off will go away once this repo picks up the ref/-related changes from dotnet/aspnetcore.
wtgodbe
deleted the
revert-2882-revert-2817-johluo/remove-testing-ref
branch
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 25, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2882
We now know how to react to removing the Ref assembly for this project - see dotnet/aspnetcore#18720. We should resolve this for 3.1.3.
Part of #2784
@JunTaoLuo @dougbu PTAL
CC @Pilchie - marking as tell-mode since this is identical to #2817