Simplify task handling in MetricCollector to avoid racy edge case #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarekgh
reviewed
Jun 27, 2023
|
|
||
| _waiters.Clear(); | ||
| // wake up anybody still waiting and inform them of the bad news: their horse is dead... |
There was a problem hiding this comment.
could you please add a comment in all places we complete the waiter.TaskSource telling need to be called outside the lock.
tarekgh
approved these changes
Jun 27, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@tarekgh I added the comments about usage of the task needing to be outside of the critical section. Unfortunately, I needed to leave the Thread.Sleep in the code since the test case is still failing. There is still something asynchronous happening which we don't understand. Can I impose on you again to figure out what's happening please? |
|
I'll try with the latest changes hopefully I can reproduce it. Looks it is failing on .NET 8.0 only now. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Microsoft Reviewers: Open in CodeFlow