Cleanup Microsoft.Extensions.Http.Resilience internals #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeknoid
reviewed
Jun 29, 2023
| using System.Net.Http; | ||
|
|
||
| namespace Microsoft.Extensions.Http.Resilience.Internal; | ||
|
|
||
| /// <summary> | ||
| /// The provider that returns the strategy key from the request message. | ||
| /// </summary> | ||
| internal interface IStrategyKeyProvider | ||
| internal sealed class StrategyKeyOptions |
There was a problem hiding this comment.
Is this type used in DI? If not, you could just be using Func<HttpRequestMessage, string> directly
There was a problem hiding this comment.
Yes, it comes from DI. This options class is just a holder for that delegate.
geeknoid
reviewed
Jun 29, 2023
| @@ -17,25 +18,22 @@ public static void SelectStrategyByAuthority(IServiceCollection services, string | |||
| { | |||
| var redactor = serviceProvider.GetRequiredService<IRedactorProvider>().GetRedactor(classification); | |||
|
|
|||
| return new ByAuthorityStrategyKeyProvider(redactor); | |||
| return new ByAuthorityStrategyKeyProvider(redactor).GetStrategyKey; | |||
There was a problem hiding this comment.
Perhaps rename GetStrategyKey to just StrategyKey?
There was a problem hiding this comment.
GetStrategyKey is just a function that gets converted to a delegate. I think the name is ok here
geeknoid
approved these changes
Jun 29, 2023
RussKie
reviewed
Jun 30, 2023
| @@ -115,4 +123,12 @@ private static IServiceCollection AddHedging(this IServiceCollection services, H | |||
|
|
|||
| return services; | |||
| } | |||
|
|
|||
| private class EmptyHandler : DelegatingHandler | |||
There was a problem hiding this comment.
[nit] Please keep one type per file. This makes it much easier to navigate the codebase - e.g., search for type in GitHub. Move to HttpClientFactory.EmptyHandler.cs.
Comment on lines
35
to
38
| internal const string StandardClient = "Standard"; | ||
|
|
||
| internal const string SingleHandlerClient = "SingleHandler"; | ||
|
|
There was a problem hiding this comment.
[nit]
Suggested change
| internal const string StandardClient = "Standard"; | |
| internal const string SingleHandlerClient = "SingleHandler"; | |
| internal const string StandardClient = "Standard"; | |
| internal const string SingleHandlerClient = "SingleHandler"; |
ghost
added this to the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifying and dropping some unnecessary internal abstractions.
Changes:
RequestMessageSnapshot.Microsoft Reviewers: Open in CodeFlow