Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EventListenerRecyclingInterval from EventCountersCollectorOptions #4178

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

xakep139
Copy link
Contributor

@xakep139 xakep139 commented Jul 16, 2023

This PR fixes #4177

Microsoft Reviewers: Open in CodeFlow

@xakep139 xakep139 linked an issue Jul 16, 2023 that may be closed by this pull request
@xakep139 xakep139 self-assigned this Jul 16, 2023
@xakep139 xakep139 requested a review from geeknoid July 16, 2023 17:39
@RussKie
Copy link
Member

RussKie commented Jul 17, 2023

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 4178 in repo dotnet/extensions

@RussKie RussKie closed this Jul 17, 2023
@RussKie RussKie reopened this Jul 17, 2023
@RussKie
Copy link
Member

RussKie commented Jul 17, 2023

This change is a breaking changes, which is typically not allowed. We've already made some API breaking changes in this release, so I suppose this is still acceptable. However, @joperezr we need to create clarity on this.

@xakep139 to fix the build the removed API have to be recorded in PublicApi.Unshipped.txt as per https://github.com/dotnet/extensions/tree/main/eng/ApiCompatibility.

@RussKie RussKie added the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Jul 17, 2023
@geeknoid
Copy link
Member

This change is a breaking changes, which is typically not allowed. We've already made some API breaking changes in this release, so I suppose this is still acceptable. However, @joperezr we need to create clarity on this.

@xakep139 to fix the build the removed API have to be recorded in PublicApi.Unshipped.txt as per https://github.com/dotnet/extensions/tree/main/eng/ApiCompatibility.

This repo will necessarily continue to have many breaking changes until November.

@RussKie RussKie removed the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Jul 17, 2023
@RussKie RussKie enabled auto-merge (squash) July 17, 2023 10:47
@RussKie RussKie merged commit 5546e37 into main Jul 17, 2023
6 checks passed
@RussKie RussKie deleted the xakep139/4177-remove-recyclinginterval branch July 17, 2023 10:55
@ghost ghost added this to the 8.0 Preview7 milestone Jul 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove EventCountersCollectorOptions.EventListenerRecyclingInterval
3 participants