Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive M.E.DependencyInjection.AutoActivation #4181

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Revive M.E.DependencyInjection.AutoActivation #4181

merged 1 commit into from
Jul 18, 2023

Conversation

geeknoid
Copy link
Member

@geeknoid geeknoid commented Jul 17, 2023 •
edited by ghost
Loading

null

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned geeknoid Jul 17, 2023
@geeknoid geeknoid requested a review from joperezr July 17, 2023 23:44
@geeknoid geeknoid changed the title Revitalize M.E.DependencyInjection.AutoActivation Revive M.E.DependencyInjection.AutoActivation Jul 18, 2023
@RussKie
Copy link
Member

RussKie commented Jul 18, 2023

FYI the new package must be recorded in dotnet/api-catalog-infra so that the Docs team has the right content for the API docs. You can use https://github.com/dotnet/api-catalog-infra/pull/63 as a reference.

@geeknoid geeknoid enabled auto-merge (squash) July 18, 2023 05:34
joperezr
joperezr approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As @RussKie mentioned above, please make sure we also add this to the catalog in order to get the package's API Docs published.

@geeknoid geeknoid merged commit 32d071f into main Jul 18, 2023
6 checks passed
@geeknoid geeknoid deleted the geeknoid/autoactivation branch July 18, 2023 15:42
@ghost ghost added this to the 8.0 Preview7 milestone Jul 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RussKie RussKie RussKie left review comments

@xakep139 xakep139 xakep139 left review comments

@joperezr joperezr joperezr approved these changes

Assignees

@geeknoid geeknoid

Labels
None yet
Projects
None yet
Milestone
8.0 Preview7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@geeknoid @RussKie @xakep139 @joperezr