Generator cleanup before updating code gen. #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeknoid
force-pushed
the
geeknoid/genclean
branch
3 times, most recently
from
0fb3694
to
43dbb90
Compare
xakep139
reviewed
Jul 29, 2023
xakep139
reviewed
Jul 29, 2023
xakep139
approved these changes
Jul 29, 2023
- Remove constraints about not starting log method names or log method parameters with _, the code now dynamically picks non-conflicting symbol names. There's still a potential conflict with the name of redactor instances, but I'll be removing all those in my follow-on PR. - Simplified logic around handling of template parameters. I couldn't figure out what the code was doing, so it needed a bit of cleanup. - Remove some dead code I stumbled on. - Fix broken .resx file handling in the generators, I messed that up when simplifying the Roslyn dependencies last week.
geeknoid
force-pushed
the
geeknoid/genclean
branch
from
43dbb90
to
aded3ce
Compare
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove constraints about not starting log method names or log method parameters with _, the code now dynamically picks non-conflicting symbol names. There's still a potential conflict with the name of redactor instances, but I'll be removing all those in my follow-on PR.
Simplified logic around handling of template parameters. I couldn't figure out what the code was doing, so it needed a bit of cleanup.
Remove some dead code I stumbled on.
Fix broken .resx file handling in the generators, I messed that up when simplifying the Roslyn dependencies last week.
Microsoft Reviewers: Open in CodeFlow