Forgot to escape JSON string output #4280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -174,6 +174,10 @@ private void OutArray(string name, Action action) | |||
|
|
|||
| private void OutNameValue(string name, string value) | |||
| { | |||
| value = value | |||
There was a problem hiding this comment.
Why not use JsonSerializer.Serialize(value) ?
There was a problem hiding this comment.
IIRC Generators can't reference packages (e.g. System.Text.Json). @geeknoid, is that correct?
There was a problem hiding this comment.
And they target NS2.0, so that wouldn't be possible, ok.
There was a problem hiding this comment.
That's what I thought until a few minutes ago. Someone just sent me https://github.com/dotnet/roslyn/blob/main/docs/features/source-generators.cookbook.md#use-functionality-from-nuget-packages which shows the MSBuild magic to make this happen.
I'll create an issue to track upgrading to that approach.
sebastienros
approved these changes
Aug 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Microsoft Reviewers: Open in CodeFlow