Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] HttpClient logging based on new .NET 8 runtime APIs (#4224) #4319

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

xakep139
Copy link
Member

@xakep139 xakep139 commented Aug 21, 2023

Microsoft Reviewers: Open in CodeFlow

* use new .NET 8 runtime APIs in HttpClient logging

* Leverage KeyedServices feature in HttpClient logging (#4253)

Co-authored-by: Nikita Balabaev <nbalabaev@microsoft.com>
@ghost ghost assigned xakep139 Aug 21, 2023
@xakep139 xakep139 changed the title HttpClient logging based on new .NET 8 runtime APIs (#4224) [release/8.0] HttpClient logging based on new .NET 8 runtime APIs (#4224) Aug 21, 2023
@geeknoid geeknoid merged commit 563313d into release/8.0 Aug 21, 2023
6 checks passed
@geeknoid geeknoid deleted the xakep139/release-8.0-cherry-pick-16b51f2 branch August 21, 2023 12:35
@joperezr
Copy link
Member

joperezr commented Aug 21, 2023

@xakep139 and @geeknoid , for future reference, merges in the direction: 8.0-rc1 -> 8.0 -> main are done automatically, and for the opposite direction (which is the case of this PR), you can now just add a comment on the original PR with a request to backport and the backport will be done automatically for you. Here is an example of when I used it for moving one change from 8.0 -> 8.0-rc1 #4287 (comment)

Essentially you just add a comment on the PR with the following format: /backport to <branchYouWantToBackportTo>

@xakep139
Copy link
Member Author

@joperezr thanks for the hint! I was aware of the automatic merges from 8.0 -> main, but didn't know about the /backport command.

@RussKie RussKie added this to the 8.0 RC2 milestone Aug 28, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants