Layer enrichment & redaction on top of HttpLogging #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xakep139
reviewed
Aug 25, 2023
src/Libraries/Microsoft.AspNetCore.Telemetry.Middleware/Logging/HttpLoggingServiceExtensions.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 25, 2023
src/Libraries/Microsoft.AspNetCore.Telemetry.Middleware/Logging/HttpLoggingServiceExtensions.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 25, 2023
src/Libraries/Microsoft.AspNetCore.Telemetry.Middleware/Logging/HttpLoggingServiceExtensions.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 25, 2023
src/Libraries/Microsoft.AspNetCore.Telemetry.Middleware/Logging/HttpLoggingTagNames.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 25, 2023
...crosoft.AspNetCore.Telemetry.Middleware/Logging/Internal/HttpLoggingEnrichmentInterceptor.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 25, 2023
src/Libraries/Microsoft.AspNetCore.Telemetry.Middleware/Logging/HttpLoggingServiceExtensions.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 25, 2023
...crosoft.AspNetCore.Telemetry.Middleware/Logging/Internal/HttpLoggingEnrichmentInterceptor.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 25, 2023
...icrosoft.AspNetCore.Telemetry.Middleware/Logging/Internal/HttpLoggingRedactionInterceptor.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 25, 2023
...icrosoft.AspNetCore.Telemetry.Middleware/Logging/Internal/HttpLoggingRedactionInterceptor.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 25, 2023
...icrosoft.AspNetCore.Telemetry.Middleware/Logging/Internal/HttpLoggingRedactionInterceptor.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Tratcher
force-pushed
the
tratcher/httplogging
branch
from
df6c8f4
to
a04ba62
Compare
geeknoid
reviewed
Oct 5, 2023
src/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware/Logging/HeaderReader.cs
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
...icrosoft.AspNetCore.Diagnostics.Middleware/Logging/HttpLoggingServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
...icrosoft.AspNetCore.Diagnostics.Middleware/Logging/HttpLoggingServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
...icrosoft.AspNetCore.Diagnostics.Middleware/Logging/HttpLoggingServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
...icrosoft.AspNetCore.Diagnostics.Middleware/Logging/HttpLoggingServiceCollectionExtensions.cs
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
...icrosoft.AspNetCore.Diagnostics.Middleware/Logging/HttpLoggingServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
src/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware/Logging/HttpLoggingTagNames.cs
Outdated
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
src/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware/Logging/LoggingRedactionOptions.cs
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
src/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware/Logging/LoggingRedactionOptions.cs
Outdated
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
src/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware/Logging/LoggingRedactionOptions.cs
Outdated
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
src/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware/Logging/LoggingRedactionOptions.cs
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
src/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware/Logging/LoggingRedactionOptions.cs
Outdated
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
...ries/Microsoft.AspNetCore.Diagnostics.Middleware/Logging/RequestHeadersLogEnricherOptions.cs
Outdated
Show resolved
Hide resolved
geeknoid
reviewed
Oct 5, 2023
src/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware/Logging/IncomingPathLoggingMode.cs
Outdated
Show resolved
Hide resolved
geeknoid
approved these changes
Oct 9, 2023
|
@geeknoid @iliar-turdushev FYI I've pushed changes to also fix #4451. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumes the new APIs from dotnet/aspnetcore#50163 to consolidate functionality. The build won't pass until we consume that PR through an updated dependency, but everything builds and tests pass locally.
Fixes #4210 #4492 #4440 #4451
Major changes:
Now that it's functional, parts of the original design should be revisited like the manual path filtering. We don't want to re-invent routing.
Microsoft Reviewers: Open in CodeFlow