Make exception summarizer work with derived exception types #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeknoid
force-pushed
the
geednoid/exsum
branch
from
8565028
to
39226c1
Compare
geeknoid
force-pushed
the
geednoid/exsum
branch
from
39226c1
to
043d734
Compare
rafal-mz
approved these changes
Sep 7, 2023
RussKie
reviewed
Sep 8, 2023
Comment on lines
-38
to
-43
| /// <summary> | ||
| /// It iterates through all registered summarizers, returns a summary if possible. | ||
| /// Default is <see cref="Exception"/> message if its length is less than 32, otherwise exception type name. | ||
| /// </summary> | ||
| /// <param name="exception">The exception.</param> | ||
| /// <returns>The summary of the given <see cref="Exception"/>.</returns> |
There was a problem hiding this comment.
Why delete the existing xml-docs? They can still be useful.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4004
Microsoft Reviewers: Open in CodeFlow