Cleanup a few misc details. #4381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
danmoseley
reviewed
Sep 8, 2023
| @@ -78,10 +76,10 @@ public class LoggingOptions | |||
| /// The default value is 1 second. | |||
| /// </value> | |||
| /// <remarks> | |||
| /// The number should be above 1 millisecond and below 1 minute. | |||
| /// The value should be in the range of 1 millisecond to 1 minute. | |||
There was a problem hiding this comment.
this must be Canadian English, like British English, as Americans say "through" ...
There was a problem hiding this comment.
Canadian English would be "the number should be above 1 millisecond, eey?"
There was a problem hiding this comment.
according to this 'through' means inclusive
https://english.stackexchange.com/a/118407
in British, 'to' could be either.
danmoseley
approved these changes
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow