-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redaction improvements. #4516
Merged
Merged
Redaction improvements. #4516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c5af39f
to
9303bf6
Compare
c354b96
to
63b5af9
Compare
xakep139
reviewed
Oct 17, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.Extra/Logging/LoggingRedactionExtensions.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 17, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.Extra/Logging/LoggingRedactionExtensions.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 17, 2023
xakep139
reviewed
Oct 17, 2023
...Microsoft.AspNetCore.Diagnostics.Middleware/Microsoft.AspNetCore.Diagnostics.Middleware.json
Outdated
Show resolved
Hide resolved
4f8acb2
to
1f86a90
Compare
xakep139
reviewed
Oct 17, 2023
src/Libraries/Microsoft.Extensions.Compliance.Redaction/RedactionExtensions.cs
Show resolved
Hide resolved
xakep139
reviewed
Oct 17, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.Extra/Logging/LoggingRedactionExtensions.cs
Show resolved
Hide resolved
xakep139
reviewed
Oct 17, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.Extra/Logging/LoggingRedactionExtensions.cs
Show resolved
Hide resolved
xakep139
reviewed
Oct 17, 2023
...Libraries/Microsoft.Extensions.Diagnostics.Extra/Microsoft.Extensions.Diagnostics.Extra.json
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 17, 2023
test/Libraries/Microsoft.Extensions.Compliance.Redaction.Tests/ErasingRedactorTests.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 17, 2023
test/Libraries/Microsoft.Extensions.Compliance.Redaction.Tests/HmacRedactorExtensionsTests.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 17, 2023
src/Libraries/Microsoft.Extensions.Compliance.Redaction/DeniedValuesAttribute.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 17, 2023
...s/Microsoft.Extensions.Compliance.Redaction/Microsoft.Extensions.Compliance.Redaction.csproj
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 17, 2023
...Microsoft.AspNetCore.Diagnostics.Middleware/Microsoft.AspNetCore.Diagnostics.Middleware.json
Outdated
Show resolved
Hide resolved
f85dac8
to
1de5b94
Compare
xakep139
reviewed
Oct 18, 2023
src/Libraries/Microsoft.Extensions.Compliance.Redaction/HmacRedactorOptions.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 18, 2023
src/Libraries/Microsoft.Extensions.Compliance.Redaction/HmacRedactorOptions.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 18, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.Extra/Logging/LoggerRedactionOptions.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 18, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.Extra/Logging/LoggerRedactionOptions.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 18, 2023
test/Libraries/Microsoft.Extensions.Compliance.Redaction.Tests/HmacRedactorTest.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 18, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.Extra/Logging/JustInTimeRedactor.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 18, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.Extra/Logging/JustInTimeRedactor.cs
Show resolved
Hide resolved
xakep139
reviewed
Oct 18, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.Extra/Logging/JustInTimeRedactor.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Oct 18, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.Extra/Logging/JustInTimeRedactor.cs
Show resolved
Hide resolved
xakep139
reviewed
Oct 18, 2023
xakep139
reviewed
Oct 18, 2023
xakep139
reviewed
Oct 18, 2023
xakep139
reviewed
Oct 18, 2023
xakep139
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, but overall looks good to me
96c48f4
to
440dc57
Compare
- Add the HMAC redactor. - Add support for salting redacted values. The salt is derived from the name of the item being redacted, and can optionally include the current day of the year (which induces daily rotation). - Delete the xxHash3 redactor.
440dc57
to
f6e5732
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the HMAC redactor.
Add support for discriminating redacted values. The discriminator is derived from the name of the item being redacted.
Microsoft Reviewers: Open in CodeFlow