Adding Microsoft.Extensions.Telemetry README #4671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Tratcher
reviewed
Nov 6, 2023
src/Libraries/Microsoft.Extensions.Compliance.Redaction/README.md
Outdated
Show resolved
Hide resolved
Tratcher
approved these changes
Nov 6, 2023
sebastienros
reviewed
Nov 6, 2023
sebastienros
reviewed
Nov 6, 2023
Co-authored-by: Chris Ross <Tratcher@Outlook.com> Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
xakep139
reviewed
Nov 7, 2023
| options.ApplyDiscriminator = true; | ||
| }); | ||
|
|
||
| builder.Services.AddRedaction(); // <- This call is required in order for the redactor provider to be added into the service collection. |
There was a problem hiding this comment.
IIRC this call requires Microsoft.Extensions.Compliance.Redaction to be referenced
xakep139
reviewed
Nov 7, 2023
|
|
||
| ```csharp | ||
| // Enable log enrichment. | ||
| builder.EnableEnrichment(options => |
There was a problem hiding this comment.
The extension method should be applied on an ILoggingBuilder
There was a problem hiding this comment.
Same applies to EnableRedaction() call
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding README for Microsoft.Extensions.Telemetry and making one small clarification on one of the Compliance READMEs to explain how RedactorProviders should be used.
Microsoft Reviewers: Open in CodeFlow