Optimize resource utilization parser for linux #4744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
approved these changes
Nov 21, 2023
Comment on lines
+14
to
+15
| /// This class is not thread safe. | ||
| /// When the same instance is called by multiple threads it may return corrupted data. |
There was a problem hiding this comment.
Suggest moving this as <remarks>. Intellisense shows those, making the discoverability easier
There was a problem hiding this comment.
Oh, it should be remarks. Thanks for spotting. :-)
geeknoid
approved these changes
Nov 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinuxUtilizationParser class is protected by lock and used internally to get utilization data from Linux OS. Parser allocates a pool of buffers at ctor time. Usage of this class makes pool of buffer writes not needed. We can just allocate one buffer writer and pass it around.
This change improves both memory that we used to maintain the pool and cycles to pass around buffer writer instance.