Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to fetch logger objects from properties and base classes. #4828

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

geeknoid
Copy link
Member

@geeknoid geeknoid commented Dec 21, 2023

  • When generating a logging method which doesn't have a logger specified as a parameter, the generator now supports fetching either a field or property from the class or any base class. It also supports either generic or non-generic loggers.

Fixes #4707

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned geeknoid Dec 21, 2023
- When generating a logging method which doesn't have a logger specified
as a parameter, the generator now supports fetching either a field or
property from the class or any base class. It also supports either
generic or non-generic loggers.
@geeknoid geeknoid enabled auto-merge (squash) December 21, 2023 18:30
@geeknoid geeknoid merged commit 40db62a into main Dec 21, 2023
6 checks passed
@geeknoid geeknoid deleted the geeknoid/loggen branch December 21, 2023 18:46
@ghost ghost added this to the 8.1 milestone Dec 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LoggerMessage] Fails to compile if a ILogger property is used instead of a field
4 participants