Ignore statics in metric source-gen #4843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xakep139
commented
Dec 28, 2023
| @@ -1,11 +1,10 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
|
|
|||
| #if false | |||
There was a problem hiding this comment.
Previously these tests were completely disabled 😕
xakep139
commented
Dec 28, 2023
| @@ -96,27 +96,6 @@ class Transitive | |||
| Assert.Contains("Test.Transitive ⇆ Test.Interim", diag.GetMessage()); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task StrongTypeCounter_CyclicReference_Guid() | |||
There was a problem hiding this comment.
This test is not relevant anymore - we don't consider Guid.Empty since it's static
RussKie
approved these changes
Dec 28, 2023
xakep139
commented
Dec 29, 2023
| @@ -688,23 +686,24 @@ private void Diag(DiagnosticDescriptor desc, Location? location, params object?[ | |||
| SpecialType specialType; | |||
| ITypeSymbol typeSymbol; | |||
|
|
|||
| if (symbol.IsImplicitlyDeclared) | |||
| if (member.IsImplicitlyDeclared || | |||
| member.IsStatic) | |||
There was a problem hiding this comment.
This is the main change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4787
This PR also enables and aligns all metering tests for generated code.
Microsoft Reviewers: Open in CodeFlow