Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable HttpClient's timeout for Standard Resilience and Hedging" #4925

Merged

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented Feb 7, 2024

Reverts #4862

See #4924 for more details.

Microsoft Reviewers: Open in CodeFlow

@eerhardt
Copy link
Member

eerhardt commented Feb 7, 2024

Do we plan on re-opening #4770?

Note I hit this myself in .NET Aspire tests. It was pretty confusing that I called AddStandardResilienceHandler and set my timeouts to be greater than 2 minutes, and it wasn't being respected.

@joperezr
Copy link
Member Author

joperezr commented Feb 7, 2024

Do we plan on re-opening #4770?

Just did.

@joperezr joperezr merged commit b5c9f8d into main Feb 7, 2024
6 checks passed
@joperezr joperezr deleted the revert-4862-mtomka/standard-resilince-httpclient-timeout branch February 7, 2024 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants