Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--binarylog option broken #2094

Open
sbomer opened this issue Feb 6, 2024 · 3 comments
Open

--binarylog option broken #2094

sbomer opened this issue Feb 6, 2024 · 3 comments
Assignees
Labels
Bug This issue describes behavior that is not working as expected

Comments

@sbomer
Copy link
Member

sbomer commented Feb 6, 2024

--binarylog no longer seems to work. I bisected dotnet-format, and it was broken by f58bc29.

This related issue is mentioned: dotnet/roslyn#70674.
According to dotnet/roslyn#71950 (comment), broken by dotnet/roslyn#70469 as part of an intentional change to the API.

@JoeRobich
Copy link
Member

Let me start by saying that a fix is planned for this break in behavior. Although, depending on how it is resolved in Roslyn, there may be a change in how it is used in dotnet-format.

However, since binary logs are a pretty big hammer, I think it is good to touch base and ensure we are providing the right feature here. These questions are open to anyone using the --binarylog option.

How are you using the generated log?
What information is it providing for you?
What questions are you answering with it?

@sbomer
Copy link
Member Author

sbomer commented Feb 7, 2024

The use case I had was this: @LakshanF and I were developing with some locally-built analyzers, and we wanted to make sure that dotnet format was picking up the right analyzer dlls by checking the binlog.

@sharwell
Copy link
Member

However, since binary logs are a pretty big hammer, I think it is good to touch base and ensure we are providing the right feature here.

I'm not sure I agree with this. In my experience, binary logs are the only hammer that matters when looking at build issues.

@sharwell sharwell added the Bug This issue describes behavior that is not working as expected label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue describes behavior that is not working as expected
Projects
None yet
Development

No branches or pull requests

5 participants