Set BuildingInsideVisualStudio to load WPF projects #1390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
force-pushed
the
load-wpf-projects
branch
6 times, most recently
from
2c4cb2b
to
d5fc5af
Compare
JoeRobich
force-pushed
the
load-wpf-projects
branch
2 times, most recently
from
6508d53
to
853097f
Compare
|
Split workspace loader tests out and rebased on #1401 |
JoeRobich
force-pushed
the
load-wpf-projects
branch
from
853097f
to
58ce61b
Compare
|
Taking this PR would cause the same regressions in blazor and blazorwasm scenarios as described in dotnet/roslyn#69225 (comment). I would prefer to see dotnet/roslyn#69225 merge in as it does not regress project loading. |
|
Closing in favor of a fix in Roslyn itself (dotnet/roslyn#69225) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1337