Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the FabricBot config for migration to Policy Service #2111

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

jeffhandley
Copy link
Member

This updates the FabricBot configuration to address issues we've seen migrating other repositories to the Policy Service automation. There is one behavioral change with a loss of functionality.

  1. Remove the auto-merge automation
    • This automation configuration was relying on some rich features of the FabricBot's own auto-merge functionality
    • That functionality was in place before GitHub's own auto-merge functionality
    • Because GitHub has built-in auto-merge capabilities, the Policy Service does not provide its own implementation
    • Policy Service does have automation that allows for a PR to have auto-merge enabled or disabled, but it can't rely on the types of conditions used here
    • The result is there is not a way to port this configuration forward, and a different approach is needed
    • The recommendation is to investigate Arcade-based auto-merge behaviors or implementing a GitHub Action
  2. Explicitly add a filter for isIssue or isPr where that was previously implied
    • There was a task configured for `"eventType" that when ported to Policy Service, this implicit filter will be lost
    • This updates the config to explicitly add that filter so behavior stays the same after the migration
  3. Remove references to project automation (it was superfluous)

/cc @mkArtakMSFT @wtgodbe @JohannesLampel

Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection to this change, but I don't know enough about Fabric Bot to understand the correctness of the change. Hopefully I can get all these rules converted to Github Actions in time to make the conversion to policy service unnecessary/irrelevant.

@jeffhandley jeffhandley merged commit 87c757a into dotnet:main Mar 6, 2024
19 checks passed
@jeffhandley jeffhandley deleted the jeffhandley/fabricbot-prep branch March 6, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants