Remove DocumentWithOptions and pass around DocumentIds

[JoeRobich]

Resolves #691

[JoeRobich]

Anecdotally this improves performance

Integration Run Before Changes

Integration Run With Changes

[jmarolf]

[tiesmaster]

@JoeRobich As a lurker in this repo, I saw this PR coming by, and I was just curious why the integration steps take this long, so I was looking into the integration tests, and what takes up its time. Opening up azure-pipelines-integration.yml, I noticed that both this repo, as Roslyn have the same hash reference (which of course cannot happen with git).

Looking at the pipeline task, I also see it fails on the checkout, so you might want to look at that.

[JoeRobich]

@ tiesmaster Thanks for lurking!

I was just curious why the integration steps take this long

Roslyn is definitely the long pole in the integration tests.

The prepare step which takes over a third of the time, is where we clone the repo, checkout the SHA we want to target, and restore all the solutions we discover. It is possible we can improve on the cloning by only checking out the SHA we care about with a depth of 1 (see https://stackoverflow.com/a/43136160).

The second longest step is Running format against the Roslyn.sln. This can be painful because there are, at last count, over 170 projects referenced. So it takes a while for the design time builds to complete so that we know which files are part of the solution. Loading fully from a design time build also provides us with the semantic information we will need to run analyzers and fixes in the future. In addition we also run against the Compiler.sln, so a double whammy there.

I noticed that both this repo, as Roslyn have the same hash reference (which of course cannot happen with git).

Thanks for spotting this. Cut and paste strikes again =)