Run naming style analyzer #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
changed the title
JoeRobich
commented
Jul 6, 2020
| // If you have changed target frameworks, make sure to update the program path. | ||
| "program": "${workspaceFolder}/artifacts/bin/dotnet-format/Debug/netcoreapp2.1/publish/dotnet-format.dll", | ||
| "program": "${workspaceFolder}/artifacts/bin/dotnet-format/Debug/netcoreapp2.1/dotnet-format.dll", |
There was a problem hiding this comment.
Updated the dotnet-format project to copy package assemblies into build folder. This is needed for finding the Feature assemblies.
| @@ -165,5 +173,42 @@ static void LogDiagnosticLocations(Solution solution, IEnumerable<Diagnostic> di | |||
|
|
|||
| return solution; | |||
| } | |||
|
|
|||
| internal static async Task<ImmutableDictionary<Project, ImmutableArray<DiagnosticAnalyzer>>> FilterBySeverityAsync( | |||
There was a problem hiding this comment.
Moved from the AnalyzerFinderHelpers.
| @@ -47,7 +49,7 @@ internal partial class AnalyzerRunner : IAnalyzerRunner | |||
| foreach (var diagnostic in diagnostics) | |||
| { | |||
| if (!diagnostic.IsSuppressed && | |||
| diagnostic.Severity >= DiagnosticSeverity.Warning && | |||
| diagnostic.Severity >= severity && | |||
There was a problem hiding this comment.
Good to filter on the correct severity.
| { | ||
| private static readonly string s_executingPath = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location); | ||
|
|
||
| private readonly string _featuresPath = Path.Combine(s_executingPath, "Microsoft.CodeAnalysis.Features.dll"); |
There was a problem hiding this comment.
Some analyzers and fixers are language agnostic.
| @@ -13,6 +13,9 @@ | |||
| <NoWarn>$(NoWarn);8002</NoWarn> | |||
| <Description>Command line tool for formatting C# and Visual Basic code files based on .editorconfig settings.</Description> | |||
|
|
|||
| <!-- Copy nuget assemblies to build directory. --> | |||
| <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies> | |||
There was a problem hiding this comment.
This makes running debug builds easier.
jmarolf
reviewed
Jul 6, 2020
| @@ -44,7 +44,7 @@ public async Task TestFilterError() | |||
| var allAnalyzers = await GetAnalyzersAsync(); | |||
| var formattablePaths = ImmutableHashSet.Create(projects.First().Documents.First().FilePath); | |||
| var minimumSeverity = DiagnosticSeverity.Error; | |||
| var result = await AnalyzerFinderHelpers.FilterBySeverityAsync(projects, | |||
| var result = await AnalyzerFormatter.FilterBySeverityAsync(projects, | |||
| allAnalyzers, | |||
jmarolf
reviewed
Jul 6, 2020
| @@ -28,7 +28,7 @@ public async Task TestFilterWarning() | |||
| var allAnalyzers = await GetAnalyzersAsync(); | |||
| var formattablePaths = ImmutableHashSet.Create(projects.First().Documents.First().FilePath); | |||
| var minimumSeverity = DiagnosticSeverity.Warning; | |||
| var result = await AnalyzerFinderHelpers.FilterBySeverityAsync(projects, | |||
| var result = await AnalyzerFormatter.FilterBySeverityAsync(projects, | |||
| allAnalyzers, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.