Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the effervescence of windows in FSharpQA tests when using hosted compiler #26

Closed
latkin opened this issue Jan 16, 2015 · 4 comments

Comments

@latkin
Copy link
Contributor

latkin commented Jan 16, 2015

For those who are actually running all of the tests, current defaults for the FSharpQA suite are to use parallel execution + hosted compiler server. This results is a new compiler server console popping up and dying away every few seconds, which is rather disruptive if you are trying to do other work.

It's a simple change to make those windows hidden, just update constant in runall.pl to CREATE_NO_WINDOW.

Hosted compiler was initially very unreliable, so it was nice to be able to see the output. But it seems sturdy enough now, I think I will change the behavior to something less disruptive.

@brodyberg
Copy link

Thanks Lincoln

On Fri, Jan 16, 2015 at 1:05 PM, Lincoln Atkinson notifications@github.com
wrote:

For those who are actually running all of the tests, current defaults for
the FSharpQA suite are to use parallel execution + hosted compiler server.
This results is a new compiler server console popping up and dying away
every few seconds, which is rather disruptive if you are trying to do other
work.

It's a simple change to make those windows hidden, just update constant in
runall.pl
https://github.com/Microsoft/visualfsharp/blob/fsharp4/tests/fsharpqa/testenv/bin/runall.pl#L3869
to CREATE_NO_WINDOW.

Hosted compiler was initially very unreliable, so it was nice to be able
to see the output. But it seems sturdy enough now, I think I will change
the behavior to something less disruptive.


Reply to this email directly or view it on GitHub
#26.

@dsyme
Copy link
Contributor

dsyme commented Jan 17, 2015

Thanks for this info. BTW I think it would make sense to make CREATE_NO_WINDOW the default.

@latkin
Copy link
Contributor Author

latkin commented Jan 19, 2015

Ok I will make that change today

@latkin latkin closed this as completed in 6fcf60f Jan 19, 2015
@dsyme
Copy link
Contributor

dsyme commented Jan 19, 2015

Thanks @latkin !

forki referenced this issue in forki/visualfsharp Jan 21, 2015
@latkin latkin added the fixed label Jan 21, 2015
KevinRansom pushed a commit that referenced this issue Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants