Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color bindings which are disposable #4618

Closed
cartermp opened this issue Mar 23, 2018 · 3 comments · Fixed by #9511
Closed

Color bindings which are disposable #4618

cartermp opened this issue Mar 23, 2018 · 3 comments · Fixed by #9511

Comments

@cartermp
Copy link
Contributor

See discussion here: fsharp/fslang-suggestions#124

Currently, the F# tools give you the ability to color types which are disposable (default is the same as classes, but they are set to Pink in my settings here):

screen shot 2018-03-23 at 8 07 29 am

There is motivation to also color bindings to types which are disposable. Today, they are not colored any differently than other bindings.

@allykzam
Copy link

I'll open a new issue if needed, but is it possible to revisit this and provide separate color bindings for the disposable type names versus disposable let-bound values? I just updated VS to 16.7 and found there's no way to go back to the old coloring, where disposable type names are a blueish green (or greenish blue?) and the let-bound value names are white.

@cartermp
Copy link
Contributor Author

@amazingant Correct, that's the case for 16.7. I've adjusted things here to allow for more customization: #9915

@allykzam
Copy link

@cartermp Awesome, thank you! 😄

@cartermp cartermp modified the milestones: Unknown / not bug, 16.8 Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants