Fix issue 10505 --- string function returns null on null parameter of type string.
#10553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r of type `string`.
vzarytovskii
approved these changes
Nov 27, 2020
cartermp
approved these changes
Nov 28, 2020
dsyme
reviewed
Dec 13, 2020
|
|
||
| when 'T : string = | ||
| if value = unsafeDefault<'T> then "" | ||
| else (# "" value : string #) // force no-op |
There was a problem hiding this comment.
The fix is needed for these lines too (further down below)
when 'T : StringBuilder = let x = (# "" value : StringBuilder #) in x.ToString()
when 'T : IFormattable = let x = (# "" value : IFormattable #) in x.ToString(null, CultureInfo.InvariantCulture)
There was a problem hiding this comment.
@dsyme good eyes, on it :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue: #10505 -
stringfunction returns null onnullparameter of typestring.The error was introduced by an optimization in a recent PR. That for any type that was discoverable at compile time as a string, it just nop'd.
The fix evaluated the value for values typed as string, and if they are null, it returns a "". This restores the original behaviour that for string nulls it returns a "", although it goes through a ton less code now :-).