Remove unused fcs support for compiling from asts #13966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
requested review from
dsyme,
eiriktsarpalis,
KevinRansom,
vzarytovskii,
psfinaki,
0101 and
abonie
dsyme
approved these changes
Sep 23, 2022
|
@T-Gro Nice work, so glad to see this go |
T-Gro
deleted the
13242-remove-unused-fcs-support-for-compiling-from-asts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes 3 entry points into F# Compiler Services.
1 is related to compiling from AST (as opposed to text)
2 are related to dynamic assembly generation
The known usages have been discussed in the linked issue #13242 and none of them identified as a showstopper.