Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser: recover on missing items in tuple patterns #13985

Merged
merged 4 commits into from
Sep 27, 2022

Conversation

auduchinok
Copy link
Member

Continuation of #13352 and #13402.

Adds recovery for missing items in tuple patterns, fixing parsing of unfinished/being edited patterns like:

let a, = 1, 2
let , a = 1, 2

match x with
| Some (1, ) -> ()
| Some (, 1) -> ()
| Some (1, , 1) -> ()

| 1, -> ()
| , 1 -> ()

@dsyme
Copy link
Contributor

dsyme commented Sep 26, 2022

Looks great!

@vzarytovskii Please pull unless we're not pulling at the moment

@vzarytovskii vzarytovskii merged commit 4f7f156 into dotnet:main Sep 27, 2022
@auduchinok auduchinok deleted the parser-tuplePat branch September 27, 2022 11:32
@vzarytovskii vzarytovskii added this to the October-2022 milestone Oct 31, 2022
auduchinok added a commit to JetBrains/fsharp that referenced this pull request Dec 7, 2022
auduchinok added a commit to JetBrains/fsharp that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants