fix go-to-definition to symbols in large files #13987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/fsharp-team-msft The fix is so simple and obviously correct, and constructing a large test case would take some time, I think we should do that in a separate PR. |
|
@vzarytovskii Probably worth getting into 17.4 |
Yes, we should cherry-pick it. |
|
It also fixes #6583. 🙂 |
|
It actually should probably target 17.4 branch directly. |
|
@vzarytovskii retargeted to 17.4, can you approve please? Thanks Is 17.4 flowing to main at the moment? |
|
@vzarytovskii actually will need to cherry pick it separately I think, I'll create a separate PR for that |
dsyme
added a commit
that referenced
this pull request
Sep 26, 2022
dsyme
added a commit
that referenced
this pull request
Sep 26, 2022
|
@auduchinok I should have read that issue more carefully, sorry |
|
This is a good fix |
T-Gro
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such a simple fix...
The problem kicks whenever we're going to symbols in files that have above 10000 symbol resolutions
Fixes #13986