Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extern keyword to SynBindingTrivia. #14030

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Add extern keyword to SynBindingTrivia. #14030

merged 3 commits into from
Oct 6, 2022

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Oct 6, 2022

Having the external keyword in the trivia could help us to format code like:

type T() =
  [<DllImport("kernel32.dll")>]
  extern UIntPtr private GetProcessHeap()

T-Gro
T-Gro previously approved these changes Oct 6, 2022
View reviewed changes
@auduchinok
Copy link
Member

@nojaf Would it be difficult to have a separate union case for extern declarations instead of reusing the let bindings one?

@nojaf
Copy link
Contributor Author

nojaf commented Oct 6, 2022

I was thinking of doing that in a future PR.
I'd first like to see how far I get with this single change.
The union case would need to be in multiple places.

@vzarytovskii vzarytovskii enabled auto-merge (squash) October 6, 2022 14:21
@vzarytovskii vzarytovskii merged commit 23d9352 into dotnet:main Oct 6, 2022
@nojaf nojaf deleted the extern-trivia branch October 7, 2022 06:06
abonie pushed a commit to abonie/fsharp that referenced this pull request Oct 7, 2022
@nojaf
Add extern keyword to SynBindingTrivia. (dotnet#14030)
6bf398d
@nojaf nojaf mentioned this pull request Oct 9, 2022
Merged
@allisonchou allisonchou mentioned this pull request Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nojaf @auduchinok @vzarytovskii @T-Gro