[RFC FS-1132] Interpolated strings syntax with multiple dollar signs #14640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonie
force-pushed
the
poc_improved_interpolation
branch
2 times, most recently
from
dcd9f6b
to
c9d5774
Compare
abonie
force-pushed
the
poc_improved_interpolation
branch
from
c9d5774
to
29abff1
Compare
abonie
force-pushed
the
poc_improved_interpolation
branch
10 times, most recently
from
5cdd52e
to
c7607ae
Compare
abonie
force-pushed
the
poc_improved_interpolation
branch
17 times, most recently
from
96be6fc
to
969ae80
Compare
added 20 commits
April 27, 2023 12:08
Using 3 bits
Replace enum<..>(..) usage in lex.fsl Use F.A ||| F.B instead of enum<F>(some int literal) in lex.fsl
Make brace matching work for interpolated strings with many braces. Adds one tests, but perhaps more tests would be good.
Refactor to keep the changes mostly contained into a new lexer rule. This makes it less likely to cause regression in regular interpolated strings and easier to put the feature behind a language version check, at a cost of some boiler-plate.
Replace call to args.diagnosticsLogger.ErrorR in lex.fsl
abonie
force-pushed
the
poc_improved_interpolation
branch
from
ed3cc38
to
503e5e2
Compare
added 2 commits
April 27, 2023 16:06
Fix some names and remove unnecessary code
abonie
force-pushed
the
poc_improved_interpolation
branch
from
6cc0353
to
0e5434a
Compare
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements this RFC.
It is still WIP, my to do list:
%before interpolation holes)$s exceeds what can be encoded