Don't show inline hint for arguments with same names as the parameters in DU #15305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudqijawabreh
force-pushed
the
DUNotShowHintSameParameterName
branch
from
61f5986
to
42c8017
Compare
baronfel
reviewed
Jun 3, 2023
vsintegration/src/FSharp.Editor/Hints/InlineParameterNameHints.fs
Outdated
Show resolved
Hide resolved
sudqijawabreh
force-pushed
the
DUNotShowHintSameParameterName
branch
from
42c8017
to
e7495fb
Compare
|
@dotnet-policy-service agree company="Foothill Technology Solutions" |
vzarytovskii
approved these changes
Jun 5, 2023
T-Gro
approved these changes
Jun 5, 2023
|
Thanks for the nice first contribution @sudqijawabreh! |
Thank you and thanks for Foothill Technology Solutions and the amplifying fsharp team for making me excited to start contributing to F#. |
psfinaki
pushed a commit
that referenced
this pull request
Jun 6, 2023
* add review comment to sb files (#15288) * add review comment to sb files * add CODEOWNERS entry for source-build * Don't show inline hint for arguments with same names as the parameters in DU (#15305) * Signature of nested type with generic type parameter (#15259) * Proof of concept * Add generic parameter names to ModuleOrType. * Revert ModuleOrType change * Process ticks in demangledPath of TType_app. * Only apply new logic when includeStaticParametersInTypeNames is active. * Use FactForNETCOREAPP * Fix build --------- Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> * Improve implied lambda and delegate argument names (#15277) * Improve implied lambda and delegate argument names * Fix * Add tests * Revert non-preview tests * Sigh * Re-revert * Fix test * Add testx --------- Co-authored-by: Oleksandr Didyk <106967057+oleksandr-didyk@users.noreply.github.com> Co-authored-by: Sudqi <sudqiomar@gmail.com> Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: kerams <kerams@users.noreply.github.com>
T-Gro
added a commit
that referenced
this pull request
Jun 6, 2023
* add review comment to sb files (#15288) * add review comment to sb files * add CODEOWNERS entry for source-build * Don't show inline hint for arguments with same names as the parameters in DU (#15305) * Signature of nested type with generic type parameter (#15259) * Proof of concept * Add generic parameter names to ModuleOrType. * Revert ModuleOrType change * Process ticks in demangledPath of TType_app. * Only apply new logic when includeStaticParametersInTypeNames is active. * Use FactForNETCOREAPP * Fix build --------- Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> * Improve implied lambda and delegate argument names (#15277) * Improve implied lambda and delegate argument names * Fix * Add tests * Revert non-preview tests * Sigh * Re-revert * Fix test * Add testx --------- Co-authored-by: Oleksandr Didyk <106967057+oleksandr-didyk@users.noreply.github.com> Co-authored-by: Sudqi <sudqiomar@gmail.com> Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: kerams <kerams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15157