Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix14779 #15384

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Fix14779 #15384

merged 3 commits into from
Jun 15, 2023

Conversation

KevinRansom
Copy link
Member

This image shows both scenarios operating correctly

Fixes:

#15258
#14779
#14779 was caused by: the parser needing an End of block following the indented submission. We use ';;'. The end of block allows the parser to reset indent expectations.

#15258 was caused by a lack of space between the # line-number statement in the submission vsfsi prepares for submission to fsi.

Image:
image

@KevinRansom KevinRansom requested a review from a team as a code owner June 13, 2023 22:21
@psfinaki psfinaki merged commit c353a33 into dotnet:main Jun 15, 2023
22 checks passed
auduchinok pushed a commit to auduchinok/fsharp that referenced this pull request Jun 15, 2023
* FSI Sometimes gets confused by tabs

* also fix 15258
@inosik
Copy link

inosik commented Oct 11, 2023

Is this supposed to be released in VS 17.7? I'm still getting the issue I reported in #15258 with 17.7.5.

@vzarytovskii
Copy link
Member

vzarytovskii commented Oct 11, 2023

Is this supposed to be released in VS 17.7? I'm still getting the issue I reported in #15258 with 17.7.5.

Likely it didn't hit the bar, please check 17.8 preview and see if it works there. I am not sure we got approval for 17.7 for it

Also, it might depend which SDK is used (in global.json) and which FSI (normal or coreclr) is used.

cc @KevinRansom

@vzarytovskii
Copy link
Member

This is what I see in 17.8:

image

@inosik
Copy link

inosik commented Oct 11, 2023

Thank you for the quick answer. I‘ll wait for 17.8 then. I just wondered, because the patch is in the release/dev17.7 branch and I thought this is the branch that 17.7.x is built off.

I‘ll also check if the CoreCLR version changes anything, because I usually use the .NET Framework version.

@KevinRansom KevinRansom deleted the fix14779 branch March 21, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants